-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Scala Native #118
Conversation
Any updates? |
The main stopper here is the fact that the build in Travis is required to pass in OpenJDK 6. Scala Native requires JDK 7+ since the compiler plugin uses the NIO file system API. So if the maintainers do not want to drop JDK 6 support, then this PR goes nowhere. Besides, there is still some work pending even dropping support for JDK 6. Mainly run the scala native build only on Scala 2.11.x and avoid the tests. I would like to have some feedback from the maintainers though on whether this is a piece of work they would be interested on having or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alonsodomin! I would definitely be interested in getting this merged. Having scala-native support would be awesome!
See my other comment on how to make Travis happy. Not the cleanest, but it works. There are also some merge conflicts to fix, but I'll be happy to merge this afterwards.
build.sbt
Outdated
@@ -43,6 +44,10 @@ lazy val `scala-parser-combinators` = crossProject.in(file(".")). | |||
jsSettings( | |||
name := "scala-parser-combinators-js" | |||
). | |||
nativeSettings( | |||
name := "scala-parser-combinators-native", | |||
scalaVersion := "2.11.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this should fix the whole Travis issue:
- scalaVersion := "2.11.11"
+ skip in compile := !scalaVersion.value.startsWith("2.11") || System.getProperty("java.version").startsWith("1.6"),
+ test := {}
@alonsodomin @gourlaysama if you can think of anything in https://github.com/scala/sbt-scala-module that would make this easier and apply to other modules, there's no problem in releasing a new version there. |
@gourlaysama @lrytz got it passing in the end, had to remove all A bit hacky but it seems to work. Maybe worth adding these settings to
|
@alonsodomin could you rebase, #120 introduced some conflicts? I'll merge this and release 1.0.7 soon after that :) |
This is an initial stab at adding support for Scala Native. Some observations on this:
PositionCache
has been implemented the same way as it was in ScalaJS (no cache).